Skip to content

[Gastown] Convoy review-then-land blocks all beads when one fails review #3708

@kilo-code-bot

Description

@kilo-code-bot

What happened?

In the review-then-land merge mode, all beads in a convoy must be approved and merged before the convoy lands to main. If any bead fails review and requires rework, the entire convoy is blocked, even if other beads are ready to be merged. This can cause unnecessary delays.

Steps to reproduce:

  1. Create a convoy with multiple beads using review-then-land merge mode.
  2. Have one bead fail review (e.g., due to missing tests).
  3. Observe that beads that have passed review cannot be merged until the failing bead is fixed.

Expected behavior:
Beads that have passed review should be able to merge independently, allowing the convoy to land partially or at least not block ready beads.

Actual behavior:
The convoy waits for all beads to pass review before any can be merged, causing delays.

Impact:
Increases lead time for features, reduces throughput.

Suggested fix:
Consider allowing beads to be merged to main as soon as they are reviewed and approved, while still tracking convoy progress. Alternatively, provide an option to allow independent merging within a convoy.

Diagram:

flowchart TD
    A[Convoy with review-then-land] --> B{All beads approved?}
    B -->|Yes| C[Merge convoy to main]
    B -->|No| D[Wait for all beads]
    D --> E[Blocked beads delay convoy]
Loading

Date: 2026-06-03

Area

Convoys

Context

  • Town ID: 54ccc5c4-f790-4457-8e47-8e2d5e715535
  • Agent: Mayor (fdb30b18-210b-42c4-a59b-cbe328810a44)
  • Rig ID: 10df468b-cdce-4e06-aba4-416118c3e49f

Recent Errors

Convoy stuck due to one bead in review

Filed automatically by the Mayor via gt_report_bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions