Incorrect logic for matching index.html

[kriszyp]

The static default index file matcher uses logic of urlPath.endsWith('index.html') which means it not only matches index.html, but also another-index.html, wrong-index.html, and really-wrong-index.html. And picks a winner in somewhat unpredictable fashion.

[Ethan-Arrowood]

Two fixes I can think of:

1. Explicitly match the string '/index.html' (with a leading /)
2. or split the urlPath.split('/') into parts, and then check the last one.

[cb1kenobi]

I like Option 1 better than split assuming the path always starts with a /. I also do love a good cached regex /\/index\.html$.

[Tmarlow98]

is this still open?

[Ethan-Arrowood]

Yes it is @Tmarlow98

I believe the particular line that needs fixing is here: https://github.com/HarperFast/harper/blob/main/server/static.ts#L54

Please keep in mind that fully-autonomous AI contributions are prohibited. Ensure you personally are manually involved in any contributions to Harper open source. Thank you and look forward to reviewing your contribution!