Skip to content

Enum DPLinkRate names in ADLXDefines.h mismatch #26

@PJVol

Description

@PJVol

Radeon Software reports incorrect "Current Link Settings", as does any other application that use the function

virtual ADLX_RESULT ADLX_STD_CALL GetDPLinkRate(ADLX_DP_LINK_RATE* linkRate) = 0

Why do you define strings in the DPLinkRateMap in the mainDisplayConnectivityExperience.cpp that mismatch names in ADLX_DP_LINK_RATE?
What's the use of this lazy fix other than demonstrating how NOT TO write code using the ADLX library?
Thanks!

    const std::unordered_map<int, std::string> DPLinkRateMap =
        {
            {0, "DP_LINK_RATE_RBR"},
            {1, "DP_LINK_RATE_2_16GBPS"},
            {2, "DP_LINK_RATE_2_43GBPS"},
            {3, "DP_LINK_RATE_HBR"},
            {4, "DP_LINK_RATE_4_32GBPS"},
            {5, "DP_LINK_RATE_HBR2"},
            {6, "DP_LINK_RATE_HBR3"},
            {7, "DP_LINK_RATE_UHBR10"},
            {8, "DP_LINK_RATE_UHBR13D5"},
            {9, "DP_LINK_RATE_UHBR20"}};

doesn't match

typedef enum
{
    DP_LINK_RATE_UNKNOWN = 0,    /**< @ENG_START_DOX The DP link rate is unknown. @ENG_END_DOX */
    DP_LINK_RATE_RBR,            /**< @ENG_START_DOX The DP link rate is 1.62 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_2_16GBPS,       /**< @ENG_START_DOX The DP link rate is 2.16 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_2_43GBPS,       /**< @ENG_START_DOX The DP link rate is 2.43 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_HBR,            /**< @ENG_START_DOX The DP link rate is 2.70 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_4_32GBPS,       /**< @ENG_START_DOX The DP link rate is 4.32 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_HBR2,           /**< @ENG_START_DOX The DP link rate is 5.40 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_HBR3,           /**< @ENG_START_DOX The DP link rate is 8.10 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_UHBR10,         /**< @ENG_START_DOX The DP link rate is 10 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_UHBR13D5,       /**< @ENG_START_DOX The DP link rate is 13.5 Gbps/Lane. @ENG_END_DOX */
    DP_LINK_RATE_UHBR20          /**< @ENG_START_DOX The DP link rate is 20 Gbps/Lane. @ENG_END_DOX */
} ADLX_DP_LINK_RATE;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions