Merge pull request #380 from DevKor-github/codex/fix-schedule-edit-deletion-bug

[codex] Fix schedule edit completion payload

Author: jjoonleo

lib/data/models/update_schedule_request_model.dart

@@ -13,7 +13,6 @@ class UpdateScheduleRequestModel {
   final int moveTime;
   final int? scheduleSpareTime;
   final String scheduleNote;
-  final int latenessTime;
 
   const UpdateScheduleRequestModel({
     required this.scheduleId,
@@ -24,7 +23,6 @@ class UpdateScheduleRequestModel {
     required this.moveTime,
     this.scheduleSpareTime,
     required this.scheduleNote,
-    this.latenessTime = 0,
   });
 
   factory UpdateScheduleRequestModel.fromJson(Map<String, dynamic> json) =>
@@ -42,7 +40,6 @@ class UpdateScheduleRequestModel {
       moveTime: entity.moveTime.inMinutes,
       scheduleSpareTime: entity.scheduleSpareTime?.inMinutes,
       scheduleNote: entity.scheduleNote,
-      latenessTime: entity.latenessTime,
     );
   }
 }

test/data/data_sources/schedule_remote_data_source_test.dart

@@ -4,6 +4,7 @@ import 'package:mockito/mockito.dart';
 import 'package:on_time_front/core/constants/endpoint.dart';
 import 'package:on_time_front/data/data_sources/schedule_remote_data_source.dart';
 import 'package:on_time_front/data/models/create_schedule_request_model.dart';
+import 'package:on_time_front/data/models/update_schedule_request_model.dart';
 import 'package:on_time_front/domain/entities/place_entity.dart';
 import 'package:on_time_front/domain/entities/schedule_entity.dart';
 import 'package:uuid/uuid.dart';
@@ -36,6 +37,8 @@ void main() {
 
   final tCreateScheduleModel =
       CreateScheduleRequestModel.fromEntity(tScheduleEntity);
+  final tUpdateScheduleModel =
+      UpdateScheduleRequestModel.fromEntity(tScheduleEntity);
 
   setUp(() {
     dio = MockAppDio();
@@ -85,48 +88,45 @@ void main() {
     });
   });
 
-  // group('updateSchdule', () {
-  //   test('should perform a PUT request on the /schedule/modify endpoint',
-  //       () async {
-  //     // arrange
-  //     when(dio.put(Endpoint.updateSchedule(scheduleEntityId),
-  //             data: tUpdateScheduleModel.toJson()))
-  //         .thenAnswer(
-  //       (_) async => Response(
-  //         statusCode: 204,
-  //         requestOptions:
-  //             RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
-  //       ),
-  //     );
-
-  //     // act
-  //     await scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);
-
-  //     // assert
-  //     verify(dio.put(Endpoint.updateSchedule(scheduleEntityId),
-  //             data: tUpdateScheduleModel.toJson()))
-  //         .called(1);
-  //   });
-
-  //   test('should throw an exception when the response code is not 204',
-  //       () async {
-  //     when(dio.put(Endpoint.updateSchedule(scheduleEntityId),
-  //             data: tUpdateScheduleModel.toJson()))
-  //         .thenAnswer(
-  //       (_) async => Response(
-  //         statusCode: 400,
-  //         requestOptions:
-  //             RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
-  //       ),
-  //     );
-
-  //     // act
-  //     final call = scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);
-
-  //     // assert
-  //     expect(call, throwsException);
-  //   });
-  // });
+  group('updateSchedule', () {
+    test('should perform a PUT request without completion fields', () async {
+      final updateJson = tUpdateScheduleModel.toJson();
+      expect(updateJson, isNot(contains('latenessTime')));
+
+      when(dio.put(Endpoint.updateSchedule(scheduleEntityId), data: updateJson))
+          .thenAnswer(
+        (_) async => Response(
+          statusCode: 200,
+          requestOptions:
+              RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
+        ),
+      );
+
+      await scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);
+
+      verify(dio.put(Endpoint.updateSchedule(scheduleEntityId),
+              data: updateJson))
+          .called(1);
+    });
+
+    test('should throw an exception when the response code is not 200',
+        () async {
+      when(dio.put(
+        Endpoint.updateSchedule(scheduleEntityId),
+        data: tUpdateScheduleModel.toJson(),
+      )).thenAnswer(
+        (_) async => Response(
+          statusCode: 400,
+          requestOptions:
+              RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
+        ),
+      );
+
+      final call = scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);
+
+      expect(call, throwsException);
+    });
+  });
 
   group('deleteSchedule', () {
     test('should perform a DELETE request on the /schedule/delete endpoint',