Skip to content

Security review 11 potential issues found #1357

@aldiboncel49-lgtm

Description

@aldiboncel49-lgtm

Security concerns in Dapp-Learning-DAO/Dapp-Learning

I was looking through the codebase and found some patterns that might be security-sensitive.


reentrancy — security/1-reentrancy/theDAO/contracts/SafeVault2.sol`:24

Severity: HIGH

Potential reentrancy — external call before state update

reentrancy — security/1-reentrancy/theDAO/contracts/BuggyVault.sol`:17

Severity: HIGH

Potential reentrancy — external call before state update

reentrancy — security/1-reentrancy/theDAO/contracts/SafeVault1.sol`:17

Severity: HIGH

Potential reentrancy — external call before state update

reentrancy — security/Analysis&POC/XSURGE/POC.sol`:65

Severity: HIGH

Potential reentrancy — external call before state update

reentrancy — security/Analysis&POC/XSURGE/SurgeToken.sol`:595

Severity: HIGH

Potential reentrancy — external call before state update

reentrancy — basic/20-flash-loan/aave/contracts/aave/FlashLoanReceiverBase.sol`:34

Severity: HIGH

Potential reentrancy — external call before state update

potential — basic/34-scroll-layer2/hardhat.config.js`:94

Severity: HIGH

Potential hardcoded credentials

potential — basic/20-flash-loan/uniswapv2/hardhat.config.js`:37

Severity: HIGH

Potential hardcoded credentials

potential — basic/20-flash-loan/uniswapv3/hardhat.config.js`:27

Severity: HIGH

Potential hardcoded credentials

potential — basic/20-flash-loan/dydx/hardhat.config.js`:66

Severity: HIGH

Potential hardcoded credentials

potential — basic/15-nft-blindbox-chainlink-vrf/hardhat.config.js`:58

Severity: HIGH

Potential hardcoded credentials


Some of these might be false positives — just wanted to put them on your radar.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions