From 848d3979e188343354bf7a1169fc04871d626cba Mon Sep 17 00:00:00 2001 From: Ajay Gol Date: Fri, 21 Aug 2026 16:20:06 +0530 Subject: [PATCH] Fix --- .../src/markdown/components/markdownEditor/MarkdownModal.tsx | 5 +---- .../FloatingTextMenu/FloatingTextFormatToolbarPlugin.tsx | 4 ++-- .../markdownEditor/plugins/MarkdownTransformers.ts | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/apphelper/src/markdown/components/markdownEditor/MarkdownModal.tsx b/apphelper/src/markdown/components/markdownEditor/MarkdownModal.tsx index 4983a5b..8f6dbb5 100644 --- a/apphelper/src/markdown/components/markdownEditor/MarkdownModal.tsx +++ b/apphelper/src/markdown/components/markdownEditor/MarkdownModal.tsx @@ -18,10 +18,7 @@ export const MarkdownModal: React.FC = ({ value, onChange, hideModal }) = const [inputVal, setInputVal] = useState(value || ""); - useEffect(() => { - if ((value || "").trim() === inputVal.trim()) return; - setInputVal(value || ""); - }, [value, inputVal]); + // Removed useEffect syncing value to inputVal to prevent loops useEffect(() => { onChange(inputVal); }, [inputVal, onChange]); diff --git a/apphelper/src/markdown/components/markdownEditor/plugins/FloatingTextMenu/FloatingTextFormatToolbarPlugin.tsx b/apphelper/src/markdown/components/markdownEditor/plugins/FloatingTextMenu/FloatingTextFormatToolbarPlugin.tsx index bbd1753..568603a 100644 --- a/apphelper/src/markdown/components/markdownEditor/plugins/FloatingTextMenu/FloatingTextFormatToolbarPlugin.tsx +++ b/apphelper/src/markdown/components/markdownEditor/plugins/FloatingTextMenu/FloatingTextFormatToolbarPlugin.tsx @@ -1,4 +1,4 @@ -import { $isCodeHighlightNode } from "@lexical/code"; +import { $isCodeHighlightNode } from "@lexical/code"; import { $isLinkNode } from "@lexical/link"; import { useLexicalComposerContext } from "@lexical/react/LexicalComposerContext"; import { mergeRegister } from "@lexical/utils"; @@ -363,7 +363,7 @@ function useFloatingTextFormatToolbar(editor: any, anchorElem: any) { if ($isRangeSelection(selection)) { const text = selection.getTextContent().trim(); - if (text && JSON.stringify(lastFormattingState === "{}")) { + if (text && JSON.stringify(lastFormattingState) === "{}") { updateFormattingState(editor); } } diff --git a/apphelper/src/markdown/components/markdownEditor/plugins/MarkdownTransformers.ts b/apphelper/src/markdown/components/markdownEditor/plugins/MarkdownTransformers.ts index 843192e..b7fa697 100644 --- a/apphelper/src/markdown/components/markdownEditor/plugins/MarkdownTransformers.ts +++ b/apphelper/src/markdown/components/markdownEditor/plugins/MarkdownTransformers.ts @@ -100,6 +100,6 @@ export const PLAYGROUND_TRANSFORMERS: Array = [ ...ELEMENT_TRANSFORMERS, CUSTOM_LINK_NODE_TRANSFORMER, - ...TRANSFORMERS.splice(0, 13), + ...TRANSFORMERS.slice(0, 13), UNDERLINE ];