Add activity-generated air speed toggle and fix adaptive comfort chart boundaries#93
Add activity-generated air speed toggle and fix adaptive comfort chart boundaries#93t-kramer wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR adds a feature flag to conditionally enable or disable activity-generated air speed in comfort calculations. A checkbox on each page (ASHRAE, EN, Compare, Ranges) allows users to toggle ChangesActivity-generated air speed feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@FedericoTartarini Please review and merge into |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@t-kramer I am struggling a bit to find the time to review all these pool requests. Shall I trust your work and we just can see what Code Rabbit says. If CodeRabbit doesn't have any major problem we can accept this pull request, please address the other issues it may find |
|
@FedericoTartarini Yes, I think we'll be fine. I didn't make any huge changes. Let's see what the review says and I'll make sure to implement any major comments. |
Summary
This PR introduces a user-facing toggle to control whether activity-generated (relative) air
speed is included in PMV calculations.
Relative air speed toggle
ASHRAE 55 requires adding a self-generated air speed component (v + 0.3 × (met − 1) when met > 1
met) to the measured air speed. This is appropriate for occupants walking, but not for people at
elevated metabolic rates without generating air movement (e.g. exercising on stationary
equipment).
A new "Relative air speed" button has been added to the button group at the bottom of the input
panel on the ASHRAE, EN 16798, Compare, and Ranges tabs (Fans & Heat and PHS are unaffected as
they do not use relative air speed). Clicking the button opens a modal dialog explaining the
feature, with a checkbox to enable or disable it.
When enabled (default), the tool adds the activity-generated component as before. When disabled,
only the measured air speed is used. Toggling the checkbox immediately recalculates and redraws
all outputs.
A display note — "Relative air speed = X m/s" — appears near the chart when relative air speed is
actively applied (met > 1 and toggle enabled), matching the existing dynamic clothing display on
ASHRAE/EN.
The underlying flag (comf.useSelfGeneratedAirSpeed) is added to comfort-models.js alongside the
existing comf.relativeAirSpeed() helper.
Summary by CodeRabbit
Release Notes