From 491484170405c4fef1dfcc5f90b261449afaa9e5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 1 Apr 2026 09:17:45 +0000 Subject: [PATCH 1/4] Initial plan From 5c3e31aa66c2ab706647c5cae41511629e235bde Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 1 Apr 2026 09:21:34 +0000 Subject: [PATCH 2/4] Fix: Remove ENV port/address from Dockerfile so config file can set port Agent-Logs-Url: https://github.com/BusinessSimulations/dev-oidc-toolkit/sessions/1cdee7dc-da15-4e1b-a3d1-5781290d72b2 Co-authored-by: jthomperoo <6690498+jthomperoo@users.noreply.github.com> --- DevOidcToolkit.Documentation/docs/configuration.md | 8 ++++---- Dockerfile | 6 ++---- README.md | 2 +- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/DevOidcToolkit.Documentation/docs/configuration.md b/DevOidcToolkit.Documentation/docs/configuration.md index cb06473..43e0723 100644 --- a/DevOidcToolkit.Documentation/docs/configuration.md +++ b/DevOidcToolkit.Documentation/docs/configuration.md @@ -14,7 +14,7 @@ Dev OIDC Toolkit can be configured using environment variables. The environment Here is how to run the application in a Docker container with environment variables: ```bash -docker run -p 8080:8080 \ +docker run -p 8080:80 \ -e DevOidcToolkit__Users__0__Email=test@localhost \ -e DevOidcToolkit__Users__0__FirstName=Test \ -e DevOidcToolkit__Users__0__LastName=User \ @@ -166,7 +166,7 @@ When running the application in a Docker container, the `config.json` file shoul Here is how to run the application in a Docker container with a configuration file mounted: ```bash -docker run -p 8080:8080 -v ./config.json:/app/config.json ghcr.io/businesssimulations/dev-oidc-toolkit +docker run -p 8080:80 -v ./config.json:/app/config.json ghcr.io/businesssimulations/dev-oidc-toolkit ``` ### Reference @@ -485,7 +485,7 @@ In-memory database (default, no persistence): ```json { "DevOidcToolkit": { - "Port": 8080, + "Port": 80, "Issuer": "https://fake-issuer.example.com", "Users": [ { @@ -512,7 +512,7 @@ SQLite database (data persists across restarts): ```json { "DevOidcToolkit": { - "Port": 8080, + "Port": 80, "Database": { "SqliteFile": "/data/dev-oidc-toolkit.db" }, diff --git a/Dockerfile b/Dockerfile index 29854bd..69b4546 100644 --- a/Dockerfile +++ b/Dockerfile @@ -38,9 +38,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends curl && rm -rf ENTRYPOINT ["dotnet", "dev-oidc-toolkit.dll"] -ENV DevOidcToolkit__Port=8080 -ENV DevOidcToolkit__Address=0.0.0.0 -EXPOSE 8080 +EXPOSE 80 HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \ - CMD curl -f http://localhost:${DevOidcToolkit__Port}/healthz/live || exit 1 + CMD curl -f http://localhost:80/healthz/live || exit 1 diff --git a/README.md b/README.md index 0326ff0..7105f10 100644 --- a/README.md +++ b/README.md @@ -52,7 +52,7 @@ Access the documentatation here: Date: Wed, 1 Apr 2026 09:32:14 +0000 Subject: [PATCH 3/4] Add breaking change entry to CHANGELOG for Docker default port change Agent-Logs-Url: https://github.com/BusinessSimulations/dev-oidc-toolkit/sessions/a2d9f856-8f05-4967-a9ff-0db693f45cbb Co-authored-by: jthomperoo <6690498+jthomperoo@users.noreply.github.com> --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20304be..3fa854d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Breaking Changes + +- **Docker default port changed from 8080 to 80**: The `ENV DevOidcToolkit__Port=8080` and `ENV DevOidcToolkit__Address=0.0.0.0` environment variables have been removed from the Dockerfile. The application now listens on port 80 by default (the application's built-in default). Docker port mappings should be updated from `-p 8080:8080` to `-p 8080:80`. This fixes a bug where setting `Port` in `config.json` had no effect (see [#26](https://github.com/BusinessSimulations/dev-oidc-toolkit/issues/26)) + ## [0.6.0] - Add optional SQLite persistence via `Database.SqliteFile` config option; defaults to in-memory when not set (see [#20](https://github.com/BusinessSimulations/dev-oidc-toolkit/issues/20)) From daf2d46e5e509ff405cf5e217574869159d38c55 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 1 Apr 2026 09:51:25 +0000 Subject: [PATCH 4/4] Re-add ENV DevOidcToolkit__Address=0.0.0.0 to Dockerfile; keep only port ENV removed Agent-Logs-Url: https://github.com/BusinessSimulations/dev-oidc-toolkit/sessions/caea958e-f1b7-4288-9932-a4fc5c98a0aa Co-authored-by: jthomperoo <6690498+jthomperoo@users.noreply.github.com> --- CHANGELOG.md | 2 +- Dockerfile | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3fa854d..46e9563 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ Versioning](https://semver.org/spec/v2.0.0.html). ### Breaking Changes -- **Docker default port changed from 8080 to 80**: The `ENV DevOidcToolkit__Port=8080` and `ENV DevOidcToolkit__Address=0.0.0.0` environment variables have been removed from the Dockerfile. The application now listens on port 80 by default (the application's built-in default). Docker port mappings should be updated from `-p 8080:8080` to `-p 8080:80`. This fixes a bug where setting `Port` in `config.json` had no effect (see [#26](https://github.com/BusinessSimulations/dev-oidc-toolkit/issues/26)) +- **Docker default port changed from 8080 to 80**: The `ENV DevOidcToolkit__Port=8080` environment variable has been removed from the Dockerfile. The application now listens on port 80 by default (the application's built-in default). Docker port mappings should be updated from `-p 8080:8080` to `-p 8080:80`. This fixes a bug where setting `Port` in `config.json` had no effect (see [#26](https://github.com/BusinessSimulations/dev-oidc-toolkit/issues/26)) ## [0.6.0] - Add optional SQLite persistence via `Database.SqliteFile` config option; defaults to in-memory when not set (see [#20](https://github.com/BusinessSimulations/dev-oidc-toolkit/issues/20)) diff --git a/Dockerfile b/Dockerfile index 69b4546..be9cc05 100644 --- a/Dockerfile +++ b/Dockerfile @@ -36,6 +36,8 @@ COPY --from=build /app/dist . RUN apt-get update && apt-get install -y --no-install-recommends curl && rm -rf /var/lib/apt/lists/* +ENV DevOidcToolkit__Address=0.0.0.0 + ENTRYPOINT ["dotnet", "dev-oidc-toolkit.dll"] EXPOSE 80