Skip to content

keys: spinning on generate keys when saving public key fails #67

@omsmith

Description

@omsmith

.catch(() => {
return new Promise(resolve => setTimeout(resolve, 100).unref())
.then(this._generateNewKeys);
});

If saving a public key fails, we wait a (short) time, generate a new key, and try again. If saving a public key will consistently fail (due to some sort of misconfiguration) this will spin CPU generating keys and trying to save them.

Would be good to either

  • Don't generate a new key, just re-attempt to save the already generated one
  • Back-off attempts to save the public key. Something something circuit breaker

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions