Commit c44cbcf
authored
Fix HIT IC z-extent: use problo[2] instead of problo[1] (#194)
In Tutorials/HIT/prob_init.cpp, Lz was computed as probhi[2]-problo[1],
a copy-paste of the Ly line. When problo[1] != problo[2] the initial
cos(2*pi*z/Lz) velocity field is not periodic in z, giving a
discontinuity across the periodic z boundary at step 0, and disagrees
with the forcing, which uses probhi[2]-problo[2] in
TurbulentForcing::init_turbulent_forcing and explicitly permits Lz > Lx.
No behavior change for the shipped inputs, which all use symmetric
prob_lo.
Fixes #1801 parent 0771d54 commit c44cbcf
4 files changed
Lines changed: 4 additions & 4 deletions
File tree
- Tutorials
- FlowPastCylinder
- HIT
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
0 commit comments